Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Request: Support WithContext and WithCancelOnError in stream #105

Open
omerfirmak opened this issue Mar 15, 2023 · 1 comment
Open

Request: Support WithContext and WithCancelOnError in stream #105

omerfirmak opened this issue Mar 15, 2023 · 1 comment

Comments

@omerfirmak
Copy link

Stream internally uses a regular pool, there is no way to upgrade it to a ContextPool, or ErrorPool
@bobheadxi
Copy link
Member

bobheadxi commented Jun 2, 2023 •
edited

@camdencheek you mentioned possibly reworking stream and/or possibly even removing it - is that still the case? If not I can add this support on Monday, extending stream with error and context-error variants seems reasonable if we keep it for 1.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@omerfirmak @bobheadxi