feat: add unused-imports plugin #230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
limitedmage
approved these changes
Nov 16, 2021
|
🎉 This PR is included in version 0.26.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds eslint-plugin-unused-imports, which identifies and reports unused imports just like TS already does, but has one distinct advantage: autofix!! Here's a recording demonstration where my editor runs
eslint --fixon save:Screen.Recording.2021-11-15.at.2.24.34.PM.mov
It's SO easy to miss an unused import locally because they hide way up at the top of your file where you're not doing actual work. If I had a dollar for every time I've amended a commit or pushed the commit
"Remove unused import"only after I realized CI failed... 🤦♀️ For those of us with setups that run eslint autofix on save, this is a lifesaver.