Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable component display name warnings for react. #245

Merged
merged 1 commit into from May 11, 2022
Merged

Enable component display name warnings for react. #245

merged 1 commit into from May 11, 2022

Conversation

thenamankumar
Copy link
Member

@erzhtor erzhtor requested a review from a team April 19, 2022 12:08
vdavid
vdavid approved these changes Apr 19, 2022
View reviewed changes
Copy link

@vdavid vdavid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't know about this setting (learned about it here just now), but this seems like a great step, I love it.

erzhtor
erzhtor approved these changes Apr 19, 2022
View reviewed changes
Copy link

@erzhtor erzhtor left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! @sourcegraph/frontend-platform, can you also take a look at this, please (Since I'm not sure if there was a specific reason why the rule was turned off previously)?

@erzhtor erzhtor mentioned this pull request Apr 20, 2022
Closed
@thenamankumar thenamankumar merged commit f35f965 into master May 11, 2022
@thenamankumar thenamankumar deleted the thenamankumar/dispaly-name branch May 11, 2022 07:48
umpox pushed a commit that referenced this pull request May 11, 2022
@thenamankumar @umpox
feat: enable component display name warnings for react. (#245)
913e156
@oleggromov oleggromov mentioned this pull request Jun 2, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vdavid vdavid vdavid approved these changes

@valerybugakov valerybugakov valerybugakov approved these changes

@erzhtor erzhtor erzhtor approved these changes

@taras-yemets taras-yemets taras-yemets approved these changes

Assignees

@thenamankumar thenamankumar

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add required displayName eslint rule
5 participants
@thenamankumar @vdavid @valerybugakov @erzhtor @taras-yemets