Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove edit feature flag #1441

Closed
taylorsperry opened this issue May 2, 2024 · 0 comments · Fixed by #1513
Closed

remove edit feature flag #1441

taylorsperry opened this issue May 2, 2024 · 0 comments · Fixed by #1513
Assignees
@pkukielka

Comments

@taylorsperry
Copy link
Contributor

taylorsperry commented May 2, 2024 •
edited by umpox

As part of removing the feature flag, we should add a "Beta" label to Edit/Document/Test (just between now and GA) and remove the old version of the test command so that users don't see two Test options:

Image
@kalanchan kalanchan assigned kalanchan and pkukielka and unassigned kalanchan May 10, 2024
@pkukielka pkukielka mentioned this issue May 15, 2024
Merged
steveyegge pushed a commit that referenced this issue May 15, 2024
@pkukielka
Remove old chat commands, add shortcuts to inline edits, groupcommands (
5a53610 
#1513)

Fixes #1441 
## Changes

One image is worth a thousand words:


![image](https://github.com/sourcegraph/jetbrains/assets/1519649/270787ca-e1d0-4d6e-ae5f-1e46fa3816f4)

![image](https://github.com/sourcegraph/jetbrains/assets/1519649/27323605-2c4f-420d-8bb5-363beb7d2286)

## Test plan

1. Test if all of the bellow works:
- click on every command
- try to use shortcut for every command
- click on every command from context menu
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pkukielka pkukielka

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove old chat commands, add shortcuts to inline edits, groupcommands sourcegraph/jetbrains
3 participants
@pkukielka @taylorsperry @kalanchan