Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JetBrains: Line number is showing one less in 'Edit Code' popup window. #1456

Closed
jay-fibi opened this issue May 6, 2024 · 0 comments · Fixed by #1492
Closed

JetBrains: Line number is showing one less in 'Edit Code' popup window. #1456

jay-fibi opened this issue May 6, 2024 · 0 comments · Fixed by #1492
Assignees
@dominiccooney
Labels
bug Something isn't working fibilabs-qa fibilabs-qa-p1

Comments

@jay-fibi
Copy link
Collaborator

jay-fibi commented May 6, 2024

Cody Version

v5.5.9

IDE Information

PyCharm 2023.3.3 (Community Edition)
Build #PC-233.13763.11, built on January 26, 2024
Runtime version: 17.0.9+7-b1087.11 aarch64
VM: OpenJDK 64-Bit Server VM by JetBrains s.r.o.
macOS 14.3
GC: G1 Young Generation, G1 Old Generation
Memory: 2048M
Cores: 8
Metal Rendering is ON
Non-Bundled Plugins:
com.sourcegraph.jetbrains (5.5.9)

Describe the bug

Platform: macOS

Steps to reproduce:

  1. Have Cody plugin installed in your JB PyCharm editor
  2. Login to Cody with PRO user
  3. Open any source code file
  4. Click on any line and check the line & column number
  5. Right click there to open context menu
  6. Choose "Cody > Edit Code" popup window
  7. Check the line & column number in the window title

Observed behavior:

line & column number in 'Edit Code' popup is showing 1 less than compared to original line & column number.

Expected behavior

Line & column number should match with exact position from where the 'Edit Code' opened.

Additional context

Video link:

https://drive.google.com/file/d/1vF5lrfA_zbAMwS1_pGh2tZN0YXE43PEt/view?usp=drive_link
@jay-fibi jay-fibi added bug Something isn't working fibilabs-qa fibilabs-qa-p1 labels May 6, 2024
@dominiccooney dominiccooney self-assigned this May 13, 2024
@dominiccooney dominiccooney mentioned this issue May 13, 2024
Merged
dominiccooney added a commit that referenced this issue May 13, 2024
@dominiccooney
Show line, column offsets in human 1-based instead of LogicalPosition…
66f80fb 
… 0-based (#1492)

Fixes #1456 

## Test plan

Tested manually:

- Enable edits with
`CODY_JETBRAINS_FEATURES=cody.feature.inline-edits=true`
- Place the cursor in a file, note line:col position in status bar
- Right click, Cody, Edit Code
- Check that the location in the dialog reflects the cursor position in
the status bar

![Screenshot 2024-05-13 at 12 30
37](https://github.com/sourcegraph/jetbrains/assets/55120/bdc42cea-15a5-45f9-80e1-dd81009807a1)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dominiccooney dominiccooney

Labels
bug Something isn't working fibilabs-qa fibilabs-qa-p1
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Show line, column offsets in human 1-based instead of LogicalPosition 0-based sourcegraph/jetbrains
2 participants
@dominiccooney @jay-fibi