Skip to content
This repository has been archived by the owner on Mar 10, 2022. It is now read-only.

Add support to github.dev/make this a web extension #199

Open
LinqLover opened this issue Sep 11, 2021 · 2 comments
Open

Add support to github.dev/make this a web extension #199

LinqLover opened this issue Sep 11, 2021 · 2 comments

Comments

@LinqLover
Copy link

At the moment, in github.dev you cannot enjoy this awesome extension:

image

This could be fixed by making this extension compatible with the web extension interface:

https://code.visualstudio.com/api/extension-guides/web-extensions

(It's not overly complicated; provided that this extension does not use node-specific features such as fs or external binaries, this looks like only defining an alternative entry point for the web extension.)

@abeatrix
Copy link
Contributor

@LinqLover Thanks for filing the issue! We are happy to announce that Sourcegraph is now a web extension as of v2.0.9.

@LinqLover
Copy link
Author

LinqLover commented Feb 23, 2022

That's awesome news! 🚀

If I go to <vscode.dev>, install the extension, and press the "Don't have an account?" link, I am redirected to this page:

image

(https://webviewview-sourcegraph-searchsidebar.vscode-webview.net/)

But when I generate and paste a token manually via https://sourcegraph.com/users/LinqLover/settings/tokens/new, the login works as expected.

Looks very nice, keep up the good work!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants