Bazel Aspect-dev: building the frontend

[jhchabran]

Aspect Migration Plan

• PNPM pre-factor
• Convert gulp generation steps to Bazel build targets
  • schema
  • graphQlSchema
  • graphQlOperations
  • cssModulesTypings
• Build & bundle @sourcegraph/web with Bazel
• Jest test examples (including jest snapshots)
• Demonstrate fast development round-trip with webpack devserver
• Demonstrate optimized fast CI
• Demonstrate BUILD file generation

More detail is in their notes doc:
https://hackmd.io/@aspect/By-gEU4Ni

Process

@ Aspect: creating any issue and tagging it with aspect-dev will bring it to this issue automatically. Our usual workflow is to only tag issues, and have PRs to close the issues.

See this page for more info: https://handbook.sourcegraph.com/departments/engineering/dev/process/tracking_issues/

For the reviewers, you can tag @jhchabran, @valerybugakov

Resources

• Bazel @ Sourcegraph
• Sourcegraph / Aspect.dev

Plan

Sourcegraph

• Eliminate circular dependencies to unblock the Bazel integration.
  • Eliminate client cross-package circular dependencies to unblock Bazel integration #45978
  • Implement CI checks to avoid introducing new client circular dependencies #45979
  • Merge the search-ui package into the branded package #46115
• Migrate from yarn to pnpm.
  • Add client packages to workspaces dependencies #45970
  • Migrate all the remaining yarn commands to pnpm #45990
  • Disable package hoisting #45991

Aspect

TODO Aspect (plan as you see fit)

Tracked issues

@unassigned

• ⭐ Devx Support Tracking issues (Q4B1)  #43746
  • (🏁 224 days ago) Make sure aspect-dev can run builds on CI #44910

Completed

• (🏁 410 days ago) CI key result metrics are centralized and aggregated in reports #33242 🛠️

@gitstart-sourcegraph

• Disable package hoisting #45991

Completed

• (🏁 186 days ago) Migrate all the remaining yarn commands to pnpm #45990 (PRs: #46143)

@jbedard

• JobFair: Bazel Tracking Issue #46486
  • (🏁 138 days ago) bazel: add bazel build,tests for client/* #46193

Completed

• (🏁 227 days ago) fix: remove circular references in build-config package #45016
• (🏁 214 days ago) bazel - build client/common + client/extension-api-types #45689
• (🏁 213 days ago) bazel: generate graphql operation interfaces, css module typings #45682
• (🏁 213 days ago) build: add missing npm dependency #45697
• (🏁 210 days ago) bazel: move general purpose rules to dev/defs.bzl #45792
• (🏁 210 days ago) build: add missing npm dependencies #45789
• (🏁 209 days ago) build: remove circular imports in client/* #45793
• (🏁 209 days ago) build: add missing npm dependencies #45826
• (🏁 209 days ago) bazel: add initial sass compilation #45831
• (🏁 208 days ago) bazel: generate graphql operation interfaces, css module typings #45756
• (🏁 208 days ago) build: remove circular imports #45866
• (🏁 207 days ago) bazel: ignore files generated into src #45922
• (🏁 206 days ago) bazel: rename generate_graphql_operations(output) to out #45946
• (🏁 205 days ago) build: add missing npm dependencies #45954
• (🏁 189 days ago) build: add missing regenerator-runtime dependency #46188
• (🏁 189 days ago) bazel: wrap module style typings in js_library() rule #46189
• (🏁 187 days ago) build: add @types/minimatch dependency #46258
• (🏁 181 days ago) build: remove branded/shared circular dep #46536
• (🏁 175 days ago) build: remove unused imports #46740
• (🏁 175 days ago) test: move client/shared testHelpers to src/testing/ #46613
• (🏁 174 days ago) build: set module type to commonjs for client tsconfig projects #46815
• (🏁 174 days ago) build: set plugin-backstage tsconfig.compilerOptions.jsx #46872
• (🏁 174 days ago) build: ensure public interfaces are exported from packages #46828
• (🏁 174 days ago) build: set plugin-backstage tsconfig.compilerOptions.jsx #46873
• (🏁 174 days ago) build: ensure public interfaces are exported from packages #46874
• (🏁 173 days ago) build: use name packages in sass imports #46906
• (🏁 168 days ago) build: upgrade bazel to 6.0.0 #47049
• (🏁 167 days ago) build: standardize scss import statements #47060
• (🏁 164 days ago) build: add sass bazel build  #47139
• (🏁 164 days ago) build: fix failing bazel targets #47222
• (🏁 138 days ago) bazel: add bazel build,tests for client/* #46193
• (🏁 137 days ago) bazel: enable js+go plugins #48520
• (🏁 133 days ago) build: move buffer,process to non-dev dependencies #48670
• (🏁 133 days ago) build: resolve dependencies injected with the webpack.ProviderPlugin  #48671
• (🏁 132 days ago) bazel: enable ReactRefreshWebpackPlugin and MonacoWebpackPlugin #48779

@jhchabran

Completed

• (🏁 227 days ago) Initial Bazel Setup #45052

@kormide

Completed

• (🏁 227 days ago) Initial bazel setup #44755
• (🏁 226 days ago) bazel: move generateGraphQlSchema.js to client/shared/dev and share code with legacy gulp build #45089
• (🏁 224 days ago) bazel: move generateGraphQlSchema.js to client/shared/dev and share c… #45090

@valerybugakov

Completed

• (🏁 221 days ago) web: remove redundant dependencies from package.json #45398
• (🏁 210 days ago) bazel: partial removal of the circular dependency wildcard / branded #45760
• (🏁 210 days ago) web: move LinkOrSpan to wildcard to partially remove circular dependency #45761
• (🏁 209 days ago) web: move Form to wildcard to partially remove circular dependency #45763
• (🏁 209 days ago) web: replace WebStory with BrandedStory in the shared package #45839
• (🏁 209 days ago) web: eliminate type import circles between shared and web #45838
• (🏁 209 days ago) web: move renderWithBrandedContext to wildcard #45807
• (🏁 208 days ago) web: separate wildcard/src/testing entry point #45889
• (🏁 206 days ago) web: extract testing package #45812
• (🏁 206 days ago) web: move Timestamp to branded #45899
• (🏁 203 days ago) web: drop legacy GraphQL schema generator #45945
• (🏁 203 days ago) web: eliminate client-api & shared circle #45948
• (🏁 203 days ago) web: merge the search package into shared #45949
• (🏁 203 days ago) bazel: add client/testing to workspace #45967
• (🏁 202 days ago) web: move global styles to wildcard #45953
• (🏁 193 days ago) web: eliminate storybook & wildcard circle #45976
• (🏁 193 days ago) web: eliminate http-client & shared circle #45977
• (🏁 189 days ago) web: migrate from yarn to pnpm #46192
• (🏁 188 days ago) vscode: migrate to pnpm #46194
• (🏁 187 days ago) web: add missing dependency #46145
• (🏁 186 days ago) web: migrate from yarn to pnpm #46143
• (🏁 174 days ago) web: add npm script for finding cross-package circular dependencies #45649

---

Sourcegraph DRI: @jhchabran (+ @quinnhare)