Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature request] infer index root by reading scip metadata #809

Open
ckipp01 opened this issue Aug 2, 2022 · 0 comments
Open

[feature request] infer index root by reading scip metadata #809

ckipp01 opened this issue Aug 2, 2022 · 0 comments

Comments

@ckipp01
Copy link

ckipp01 commented Aug 2, 2022

Currently using using src to upload a SCIP file it assumes that the root is the directory the actual directory the index is in. You can see this in:

// inferIndexRoot returns the root directory based on the configured index file path.
//
// Note: This function must not be called before codeintelUploadFlagset.Parse.
func inferIndexRoot() (string, error) {
return codeintel.InferRoot(codeintelUploadFlags.file)
}

There are situations where an integrations may spit this file out not in the root of the dir. Then when you upload you need to ensure you're setting -root or it may be inferred incorrectly.

As an alternative I'd be great if this could just be pulled form the project_root field of the metadata in the scip protocol. This would allow for an upload that is uploading a scip.index file not in the root to also not have to define the -root flag.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants