Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reverse proxy should be optional #100

Open
onknows opened this issue Mar 13, 2016 · 8 comments
Open

Reverse proxy should be optional #100

onknows opened this issue Mar 13, 2016 · 8 comments

Comments

@onknows
Copy link

onknows commented Mar 13, 2016

In most cases a reverse proxy is not needed. If a reverse proxy is needed more than likely it will be configured in a separate cookbook.

Typically you don't create a reverse proxy per product. You would use reverse proxy for JIRA, Confluence and possibly other products. But you won't want a proxy for JIRA, one for Confluence.

IMHO the cookbook will be more useful if it possible to exclude the reverse proxy. Or better, if it is optional.

For testing purposes it may be useful to have reverse proxy as a option I'm not sure.

@legal90
Copy link
Contributor

legal90 commented Mar 22, 2016

@onknows Thank you for proposal. I agree that sometimes it could be desirable to configure reverse proxy outside of this application cookbook, so it makes sense.

However, at the moment I can't provide a good solution for that, but we are open for pull-requests :)

@mrjcleaver
Copy link

How about a flag such that https://github.com/parallels-cookbooks/confluence/blob/master/recipes/default.rb#L26 only runs if the flag to use a proxy is set?

@mrjcleaver
Copy link

?

@onknows
Copy link
Author

onknows commented Nov 2, 2016

Sure, that does it.

@mrjcleaver
Copy link

@patcon FYI

@et304383
Copy link

Anything that can be done to move this along folks? We'd like installing apache2 to be optional as well based on a flag like the JIRA cookbook does it:

https://github.com/afklm/jira/blob/master/recipes/default.rb#L8

@damacus
Copy link
Member

damacus commented May 9, 2019

Closing due to inactivity.

If this is still an issue please reopen or open another issue. Alternatively drop by the #sous-chefs channel on the Chef Community Slack and we'll be happy to help!

Thanks,
Sous-Chefs

@damacus damacus added this to Needs triage in Projects A-G May 11, 2019
@github-actions
Copy link

Marking stale due to inactivity. Remove stale label or comment or this will be closed in 7 days. Alternatively drop by the #sous-chefs channel on the Chef Community Slack and we'll be happy to help! Thanks, Sous-Chefs.

@github-actions github-actions bot added the Stale label Sep 30, 2020
@xorimabot xorimabot removed the Stale label Sep 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Projects A-G
  
Needs triage
Development

No branches or pull requests

7 participants