Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hostname should be included on default value of mydestination #108

Open
brauliobo opened this issue Jun 8, 2015 · 3 comments
Open

Hostname should be included on default value of mydestination #108

brauliobo opened this issue Jun 8, 2015 · 3 comments
Labels
Feature Request Enhancement to existing functionality or new functionality Help Wanted Assistance is required to resolve this issue Tech Debt Will improve the maintainability of the codebase

Comments

@brauliobo
Copy link

default['postfix']['main']['mydestination'] = [node['postfix']['main']['myhostname'], node['hostname'], 'localhost.localdomain', 'localhost'].compact

This makes delivery fails to node['postfix']['main']['myhostname'] and node['hostname'] if the receiver server is at another host.

This also makes override complicated as it can't be done on roles, just directly on node attributes.

I can make a pull request if you agree.

@chasebolt
Copy link
Contributor

@bradenwright can you please provide more detail on this? From the postfix docs it appears to be correct. If you do not want this box to handle mail for itself then you can redefine the attribute in your wrapper. override['postfix']['main']['mydestination'] = ['localhost.localdomain', 'localhost']

"The mydestination parameter specifies what domains this machine will deliver locally, instead of forwarding to another machine. The default is to receive mail for the machine itself."

@bradenwright
Copy link

@chasebolt think you may have accidentally included me on this but if I'm wrong then I'd need more info.

Anyways personally I don't see any problems with including it in default or overriding the attribute in recipe/role.

@chasebolt
Copy link
Contributor

Sorry @bradenwright tabbed a bit early and didn't notice the incorrect mention!

@brauliobo

@damacus damacus added Feature Request Enhancement to existing functionality or new functionality Help Wanted Assistance is required to resolve this issue Tech Debt Will improve the maintainability of the codebase labels Oct 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Request Enhancement to existing functionality or new functionality Help Wanted Assistance is required to resolve this issue Tech Debt Will improve the maintainability of the codebase
Projects
None yet
Development

No branches or pull requests

6 participants