Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contribution guide #5

Open
lbailly opened this issue Mar 11, 2018 · 12 comments
Open

Contribution guide #5

lbailly opened this issue Mar 11, 2018 · 12 comments
Assignees
Milestone

Comments

@lbailly
Copy link

lbailly commented Mar 11, 2018

Hi Guys,

Congrats for the job!

I'm thinking about adding B2B Wallet WS support.

Did you provide any guide to help contributing to the project ?
How did you convert WSDL to structs for example ?

Thanks,

Ludovic

@smgladkovskiy
Copy link
Collaborator

Hi, Ludovic!

Thank you for your interest and sorry for the long response.

Now the project is deep development and we have not even imagined that we can interest someone with current progress. In view of this, the contribution guide was not formed. We will try the other day to draft it and introduce it to the community.

As for the generation of structures, there is a lot of manual work. Although initially the library gowsdl was very helpful.

And we will be very pleased with pull request! :)

@lbailly
Copy link
Author

lbailly commented Mar 14, 2018

Hi Sergey,

Thanks for your response.
Happy to find other people interested in using Amadeus WS in golang :-)

I can see that you pushed updates and implemented newer versions of the services as well as soap4 new header that's great.

I'll take a deeper look and would appreciate if you could add a basic example using soap4 + call to a simple service in order to get started.

Not easy to implement soap client in GO, I'm using gowsdl for other API too.

Thanks,

Ludovic

@smgladkovskiy
Copy link
Collaborator

I'll take a deeper look and would appreciate if you could add a basic example using soap4 + call to a simple service in order to get started.

Coming soon!

@sinus89
Copy link
Contributor

sinus89 commented Mar 15, 2018

Examples added.

@lbailly
Copy link
Author

lbailly commented Mar 15, 2018

Thanks, I'll clone the repo and try that soon

@smgladkovskiy
Copy link
Collaborator

👍

@PawelKaev
Copy link

PawelKaev commented Mar 20, 2018

Здравствуйте!. Хотелось бы увидеть пример в браузере. Какой адрес надо указать? С теми, что в примере не получается запустить пример.

@PawelKaev
Copy link

PawelKaev commented Mar 20, 2018

и еще один вопрос. То что в скобках (organizationId), надо поменять на то, что получено от amadeus?
Пример: в строке DataLength: formats.NumericInteger_Length1To15(passwordLength), вставляем в место "passwordLength" цифру 8. и так во всем коде.

@PawelKaev
Copy link

В файле "authenticate" надо ли поменять строки:
sa "github.com/tmconsulting/amadeus-golang-sdk/reqstructs/security_authenticate"
soap2 "github.com/tmconsulting/amadeus-golang-sdk/soap2.0" ????????????

@zeroabe
Copy link
Contributor

zeroabe commented Mar 20, 2018

Hi, Pawel. I'm realy sorry, but i can't understand what exactly you want? This repo is SDK. What examples in browser do you need? Just use it to implement your own web app.
Or you can clarify you question.

@zeroabe
Copy link
Contributor

zeroabe commented Mar 20, 2018

Two words about brackets.
Don't you saw lisp code? There are too many brackets too

@PawelKaev
Copy link

PawelKaev commented Mar 20, 2018 via email

@smgladkovskiy smgladkovskiy added this to the v1.x.x milestone Jul 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants