Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support closing parentheses in URLs do not match #30

Open
3 tasks done
michelnev opened this issue Nov 24, 2023 · 3 comments
Open
3 tasks done

Support closing parentheses in URLs do not match #30

michelnev opened this issue Nov 24, 2023 · 3 comments
Labels
bug Something isn't working

Comments

@michelnev
Copy link

Describe the bug

Node.js version: v20.9.0

OS version: FreeBSD freebsd 13.2-RELEASE-p4

Description: URL with ) characters are not matched.

Actual behavior

Testing with an exact match against a url like http://foo.com/blah_blah_(wikipedia) returns false.

Expected behavior

Testing with an exact match against a URL like http://foo.com/blah_blah_(wikipedia) should return true.

Code to reproduce

const urlRegex = require( 'url-regex-safe' );

const s0 = 'http://foo.com/blah_blah_(wikipedia';
const s1 = 'http://foo.com/blah_blah_(wikipedia)';

// Returns true as expected
console.log(urlRegex({exact: true}).test(s0));

// Should be true, but return false
console.log(urlRegex({exact: true}).test(s1));

Checklist

  • I have searched through GitHub issues for similar issues.
  • I have completely read through the README and documentation.
  • I have tested my code with the latest version of Node.js and this package and confirmed it is still not working.
@michelnev michelnev added the bug Something isn't working label Nov 24, 2023
@titanism
Copy link
Contributor

PR welcome!

@IITII
Copy link

IITII commented Jan 31, 2024

also need for this

@titanism
Copy link
Contributor

PR is welcome

@spamscanner spamscanner locked as spam and limited conversation to collaborators Jan 31, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants