Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use If-Modified-Since when fetching appcast #371

Open
kornelski opened this issue Jul 7, 2014 · 3 comments
Open

Use If-Modified-Since when fetching appcast #371

kornelski opened this issue Jul 7, 2014 · 3 comments

Comments

@kornelski
Copy link
Member

No description provided.

@kornelski kornelski added this to the 1.9 milestone Jul 14, 2014
@kornelski kornelski removed this from the 1.9 milestone Jan 14, 2015
@zorgiepoo
Copy link
Member

This could be useful. Tricky part may be caching based on the updater bundle + old bundle to update.

@lostminds
Copy link

I'm not sure what this exactly refers to, but if it refers to checking the appcast modified date on the server this could be misleading if the appcast is not a static file. In my setup the appcast is for example dynamically generated by a version management backend on the server that handles versions across the website, downloads, appcast and other external updates.

@kornelski
Copy link
Member Author

If the server doesn't generate Last-Modified or doesn't actively parse If-Modified-Since and respond with 304, then it won't have any effect and will behave just like a regular file download.

The only situation where it could cause problems would be if you intentionally implemented support for request validation and did it incorrectly. But that's not really different from incorrectly implementing any other aspect of feed serving.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants