Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[admin v3] add WorldUsersProvider to fix 馃挘 #1758

Open
denisdimitrov opened this issue Jul 8, 2021 · 5 comments
Open

[admin v3] add WorldUsersProvider to fix 馃挘 #1758

denisdimitrov opened this issue Jul 8, 2021 · 5 comments
Assignees
Labels
馃悰 bug A bug, error, issue, problem, etc within the platform.

Comments

@denisdimitrov
Copy link
Contributor

denisdimitrov commented Jul 8, 2021

WorldUsersProvider wrapper needs to be added to admin v3 to fix the crashing of the page. This might need some research on how to be done correctly since there are multiple v3 pages that can be accessed. Maybe the initial one would be enough if they are in the same sub router.

Here is the fix for admin v1:
#1757 (comment)

@denisdimitrov denisdimitrov added the 馃悰 bug A bug, error, issue, problem, etc within the platform. label Jul 8, 2021
@denisdimitrov denisdimitrov changed the title [admin v3] add worlds users provider to fix 馃挘 [admin v3] add WorldUsersProvider to fix 馃挘 Jul 8, 2021
@0xdevalias
Copy link
Contributor

I think this may have been resolved by some of the work @goran-peoski-work did the other day with the <Provided withWorldUsers withRelatedVenues> component.

We should find/link that PR here, and if it resolves this issue, then we can close it off, etc.

@goran-peoski-work
Copy link
Contributor

goran-peoski-work commented Jul 19, 2021

There are few PRs that touch on providers for Admin (v1,v2,v3):

@whoaitsaimz
Copy link
Contributor

Hey @ermiaSparkle can we confirm if this is done? Issue was created on the public repo.

@ermiaSparkle
Copy link
Contributor

Qa and close it tomorrow

@whoaitsaimz
Copy link
Contributor

It's a question for @mike-lvov

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
馃悰 bug A bug, error, issue, problem, etc within the platform.
Projects
None yet
Development

No branches or pull requests

5 participants