Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Official GPL-1.0 license text is not being matched correctly by LicenseCompareHelper.isTextStandardLicense() #231

Open
pmonks opened this issue Mar 26, 2024 · 1 comment

Comments

@pmonks
Copy link
Collaborator

pmonks commented Mar 26, 2024

When org.spdx.utility.compare.LicenseCompareHelper.isTextStandardLicense().isDifferenceFound() is run on the official GPL-1.0 license text, it (incorrectly) returns true (i.e. the standard license was not matched). When I run org.spdx.utility.compare.LicenseCompareHelper.isTextStandardLicense().getDifferenceMessage() on it, I get:

Additional text found after the end of the expected license text starting at line #192 column #21 "end"

However the GPL-1.0 SPDX template does appear to (correctly) contain the text END OF TERMS AND CONDITIONS at this point (albeit in an <optional> block).

This was reproduced with Spdx-Java-Library v1.11 and SPDX license list v3.23.

@pmonks
Copy link
Collaborator Author

pmonks commented Mar 26, 2024

Note: the same thing appears to be happening with the official GPL-2.0 license text as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant