Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unexpected behavior comparing SPDX documents with no local LicenseRef text #65

Open
goneall opened this issue Feb 16, 2021 · 5 comments
Labels
wontfix This will not be worked on

Comments

@goneall
Copy link
Member

goneall commented Feb 16, 2021

When comparing 2 SPDX documents with a LicenseRef containing no text, the comparison of those LicenseRef's is false, but no explanation is given.

We probably do not want them to match since we don't have the text to compare, but we could list them in the Extracted Licenses tab as EMPTY.

@goneall
Copy link
Member Author

goneall commented Feb 16, 2021

This is related to spdx/tools#267

@goneall
Copy link
Member Author

goneall commented Aug 31, 2021

Attaching a test file with an empty license text and the resultant compare xlsx spreadsheet when comparing to itself.
SPDXTagExample-v2.2-no-text1.spdx.txt
result.xlsx

@goneall
Copy link
Member Author

goneall commented Aug 31, 2021

I'm going to leave this open for now - not sure if we should match empty text or not.

Note that the Verification tab does show that there is missing required license text.

@goneall
Copy link
Member Author

goneall commented Aug 31, 2021

Moving this issue to the Spdx-Java-Library since the fix (if we decide this is a bug) would be in the license compare code in the library.

@goneall goneall transferred this issue from spdx/tools-java Aug 31, 2021
@goneall goneall added the wontfix This will not be worked on label Sep 26, 2021
@goneall
Copy link
Member Author

goneall commented Sep 26, 2021

Labeling this as "won't fix" - Since license text is required per spec and the tool, the behavior in matching an invalid SPDX document doesn't need to be defined.

@goneall goneall closed this as completed Sep 26, 2021
@goneall goneall reopened this Sep 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

1 participant