Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Schema to disallow lists inside of paragraphs #1758

Open
goneall opened this issue Dec 25, 2022 · 2 comments · May be fixed by #1762
Open

Update Schema to disallow lists inside of paragraphs #1758

goneall opened this issue Dec 25, 2022 · 2 comments · May be fixed by #1762
Labels
XML markup change potential change or addition to XML markup in license XML schema change
Milestone
Later Release

Comments

@goneall
Copy link
Member

goneall commented Dec 25, 2022

Some license HTML files are being flagged as invalid due to lists being included inside paragraphs in issue #1680

From this Stack Overflow article, it looks like lists should not be allowed inside paragraph tags.

Note that this will be a slightly messy update to the schema since the current paragraph tag is specified in 3 different parts of the schema and re-use type information.
@goneall goneall mentioned this issue Dec 25, 2022
Open
@swinslow swinslow added XML schema change XML markup change potential change or addition to XML markup in license labels Dec 26, 2022
@swinslow swinslow added this to the 3.20 milestone Dec 26, 2022
@zvr
Copy link
Member

zvr commented Dec 26, 2022

Right, in HTML lists cannot be inside paragraphs.

One may omit the end tag of a paragraph, but it is considered to be closing when a list-begin tag (<ul> or <ol>) is encountered.

goneall added a commit that referenced this issue Dec 26, 2022
@goneall
Update schemas to dissallow lists in paragraphs
cd28a75 
Fixes #1758

Signed-off-by: Gary O'Neall <gary@sourceauditor.com>
@goneall goneall linked a pull request Dec 26, 2022 that will close this issue
Open
@jlovejoy jlovejoy modified the milestones: 3.20, 3.21 Feb 15, 2023
@swinslow swinslow modified the milestones: 3.21, 3.22 Jun 18, 2023
@swinslow swinslow modified the milestones: 3.22, 3.23 Sep 30, 2023
@jlovejoy jlovejoy modified the milestones: 3.23, 3.24 Feb 7, 2024
@jlovejoy
Copy link
Member

jlovejoy commented May 9, 2024

@swinslow @goneall @zvr - moving this to "later release" as it's been open for a long time... is there an action item here?

@jlovejoy jlovejoy modified the milestones: 3.24, Later Release May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
XML markup change potential change or addition to XML markup in license XML schema change
Projects
None yet
Milestone
Later Release
Development

Successfully merging a pull request may close this issue.

Update schemas to disallow lists in paragraphs spdx/license-list-XML
4 participants
@zvr @goneall @swinslow @jlovejoy