Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update SMLNJ to allow matching to the included text #2411

Closed
siddhesh opened this issue Feb 29, 2024 · 7 comments · Fixed by #2473
Closed

Update SMLNJ to allow matching to the included text #2411

siddhesh opened this issue Feb 29, 2024 · 7 comments · Fixed by #2473
Assignees
Labels
XML markup change potential change or addition to XML markup in license
Milestone

Comments

@siddhesh
Copy link
Contributor

1. License Name: Historical Permission Notice and Disclaimer with docs disclaimer
2. Short identifier: HPND-docs-disclaimer
3. License Author or steward: Unknown
4. Comments: This license is used in Fedora through newlib and was found during license review: https://gitlab.com/fedora/legal/fedora-license-data/-/issues/486
5. License Request Url: http://tools.spdx.org/app/license_requests/356
6. URL(s):
7. OSI Status: Unknown
8. Example Projects:
8. License Text Diff: https://github.com/spdx/licenseRequestImages/blob/master/02521c6b-f58c-498b-8833-b61acc0c2e87.png

Note:
The license closely matched with the following license ID(s): SMLNJ

@karsten-klein
Copy link

ScanCode
reference id: cmu-uc
matched id: standard-ml-nj

{metæffekt} Universe
canonical name: Permission Terms CWI
short name: PT-CWI
Open CoDE status: (approved)
Open CoDE similar license id: MIT-CMU

Comment
As one can see the core license part is pretty generic. We derived the template from the CWI License in Python License 2.0. The MIT from CMU also looks quite similar and may be a better fit.
We'll probably will generalize this to a Permission Terms without a specific association to a copyright holder. Please also note, that the ScanCode standard-ml-nj
looks quite different to the SPDX template, while it links to SPDX's SMLNJ.

@jlovejoy
Copy link
Member

@jlovejoy
Copy link
Member

This is indeed a match to https://spdx.org/licenses/SMLNJ.html
note the only difference are in how the name is expressed and that is "replaceable" as per SPDX matching guidelines

@karsten-klein - I checked the ScanCode standard-ml-nj and it matches. It looks like they have simply replaced "Lucent" (and other such specific names) with a generic reference to author, which would also be a match.

@jlovejoy
Copy link
Member

I'll close this issue shortly

@xsuchy
Copy link
Collaborator

xsuchy commented Apr 7, 2024

Copying @richardfontana comment from fedora-license-data repo:
If I'm not mistaken, it is not a match, because it has "that the copyright notice" instead of "the copyright notice", so would require (presumably) a markup change on the SPDX side.

@jlovejoy
Copy link
Member

ugh, indeed, there is an extra "that" in there which makes no sense and is probably a typo, but I've now added a PR for markup for this.

@jlovejoy jlovejoy added XML markup change potential change or addition to XML markup in license and removed already on SPDX License List labels May 14, 2024
@swinslow
Copy link
Member

ugh, indeed, there is an extra "that" in there which makes no sense and is probably a typo

Yup -- at a wild guess, it may be carried through from the original OSI template for HPND:

[and] that both [that] [the] copyright notice and this permission notice appear

I assume the HPND template was originally framed this way to match to "that copyright notice" and "the copyright notice". But someone could also do both, I guess :)

In any case, +1 to make that "that" optional.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
XML markup change potential change or addition to XML markup in license
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants