Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CC-BY-3.0 template is missing a line of text compared to the Creative Commons-published texts, causing matching to fail #2431

Closed
pmonks opened this issue Mar 26, 2024 · 4 comments
Assignees
Labels
minor updates to file URL update, notes update, etc.
Milestone

Comments

@pmonks
Copy link
Contributor

pmonks commented Mar 26, 2024

The CC-BY-3.0 license text published by Creative Commons commences with this text:

Creative Commons Legal Code

But the associated SPDX template is missing this text, so matching against the Creative Commons-published text fails.

@karsten-klein
Copy link

{metæffekt} Universe
canonical name: Creative Commons BY 3.0
markers: Incompatible with Secondary License Marker
category: CC-BY
SPDX reference id: CC-BY-3.0
ScanCode reference id: cc-by-3.0
OSI status: pending
Open CoDE status: approved
Open CoDE approved license id: CC-BY-3.0 (SPDX)

ScanCode
matched id: cc-by-3.0

@xsuchy
Copy link
Collaborator

xsuchy commented Apr 3, 2024

nod, we are missing this text
+1 to add it there
It will make no harm to have there more text because according to https://spdx.github.io/spdx-spec/v2.3/license-matching-guidelines-and-templates/#b3-substantive-text it should be ignored anyway.

@jlovejoy jlovejoy added the minor updates to file URL update, notes update, etc. label Apr 4, 2024
@jlovejoy jlovejoy added this to the 3.24 milestone Apr 4, 2024
@jlovejoy
Copy link
Member

jlovejoy commented Apr 4, 2024

Thanks @pmonks and good catch. This makes me wonder if there are any other CC licenses with the same issue?

In any case, I think we can just update the titleText tag for this. @pmonks - do you want to create a PR for that?

pmonks added a commit to pmonks/license-list-XML that referenced this issue Apr 9, 2024
@pmonks
Copy link
Contributor Author

pmonks commented Apr 9, 2024

@jlovejoy I did check one or two of the CC-BY-*-4.0 license texts, and they don't have this line, so they're unaffected. I didn't check either CC-BY-*-1.0 or CC-BY-*-2.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
minor updates to file URL update, notes update, etc.
Projects
None yet
Development

No branches or pull requests

4 participants