Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove 'exploited' field in model/Security/Classes/ExploitCatalogVulnAssessmentRelationship.md #652

Open
VenkatTechnologist opened this issue Feb 24, 2024 · 10 comments
Milestone

Comments

@VenkatTechnologist
Copy link
Contributor

VenkatTechnologist commented Feb 24, 2024

Per my understanding, a vulnerability is entered into an exploit catalog such as KEV only when it has been already exploited.
If we know that it has been already exploited, why do we need a Boolean field known as 'exploited' to indicate if it has been
exploited or not? I suggest removing this field (unless there's a case when a vulnerability will return back to
'unexploited' from 'exploited', which I don't think it will ever will).

@goneall goneall added this to the 3.0-rc3 milestone Mar 4, 2024
@goneall
Copy link
Member

goneall commented Apr 3, 2024

@VenkatTechnologist is this still valid based on your current analysis?

@goneall
Copy link
Member

goneall commented Apr 3, 2024

@jeff-schutt - Thoughts?

@VenkatTechnologist
Copy link
Contributor Author

VenkatTechnologist commented Apr 4, 2024

@VenkatTechnologist is this still valid based on your current analysis?

Yes. This is being currently discussed in some forums. The overall opinion seems to be that once there's an exploit, it will always remain an exploit (true). And hence, this field seems redundant.

Here's one discussion that I came across:

https://www.linkedin.com/posts/jayjacobs1_vulnerability-vulnerabilitymanagement-vulnerabilityassessment-activity-7167539737052868608-rQXD?utm_source=share&utm_medium=member_desktop

@goneall
Copy link
Member

goneall commented Apr 4, 2024

@puerco @jeff-schutt - Can you review / weigh in - we need to close these before the 3.0 release which is coming up quick

@VenkatTechnologist
Copy link
Contributor Author

VenkatTechnologist commented Apr 4, 2024

I presume there might be some consultations required with industry experts, which might take time.

@goneall
Copy link
Member

goneall commented Apr 4, 2024

Since removing this will be a breaking change - we need to make a decision within the next few days. If we remove it, adding it back would not be a breaking change and could be done in 3.1.

Waiting for @jeff-schutt and @puerco to weigh in.

@kestewart kestewart modified the milestones: 3.0-rc3, 3.0 Apr 7, 2024
@jeff-schutt
Copy link
Collaborator

Yes, the logic of the argument holds: once exploited, a vuln in a particular software version will remain exploitable.

When we discussed this we decided that the extra information would be beneficial for a different reason. Consider that there are likely to be multiple exploit catalogs from which one could correlate vulnerability exploitation. Keeping this field allows one to search the graph or an SPDX document without having to know the name of every catalog that might be listed.

I recommend that we leave the field in the spec.

@VenkatTechnologist
Copy link
Contributor Author

VenkatTechnologist commented Apr 9, 2024 via email

@rnjudge
Copy link
Collaborator

rnjudge commented Apr 10, 2024

Deferring to 3.1 per comment above.

When we discussed this in the security call today a comment was made that this is a technical issue (with JSON-LD) being transposed on the model but @tsteenbe strongly advocated for this from the beginning of the security profile.

@rnjudge rnjudge modified the milestones: 3.0, 3.1 Apr 10, 2024
@VenkatTechnologist
Copy link
Contributor Author

VenkatTechnologist commented Apr 11, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants