Merge JSON saving into main #104
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ujjwal Agarwal <ujjwalcoding012@gmail.com>
- parsed other licenses from spdx.Doxument2_2 to json - tests pending Signed-off-by: Ujjwal Agarwal <ujjwalcoding012@gmail.com>
- Saved annoations on the root document from struct to json - unit tests pending Signed-off-by: Ujjwal Agarwal <ujjwalcoding012@gmail.com>
- Saved document describes from spdxStruct to json - unit tests pending from this section Signed-off-by: Ujjwal Agarwal <ujjwalcoding012@gmail.com>
- saved packages from spdx struct to json - saved relationships froms spdx struct to json Signed-off-by: Ujjwal Agarwal <ujjwalcoding012@gmail.com>
- parsed files information from struct to json - unckaged files spdx map altered (find a fix around it ) Signed-off-by: Ujjwal Agarwal <ujjwalcoding012@gmail.com>
- save snippets information from spdx struct to json - unit tests for render function pending Signed-off-by: Ujjwal Agarwal <ujjwalcoding012@gmail.com>
Signed-off-by: Ujjwal Agarwal <ujjwalcoding012@gmail.com>
- Write bytes from bytes.buffer to io.Writer while parsing json Signed-off-by: Ujjwal Agarwal <ujjwalcoding012@gmail.com>
- Parse a jsonsaved file using jsonloader and fixx the bugs discovered Signed-off-by: Ujjwal Agarwal <ujjwalcoding012@gmail.com>
- Don't remove () suffix while parsing creator person and organization Signed-off-by: Ujjwal Agarwal <ujjwalcoding012@gmail.com>
Signed-off-by: Ujjwal Agarwal <ujjwalcoding012@gmail.com>
- Unnecessary functioanlity of maintinging the order of properyies removed
- usage of map[string]interafce{} introduced
Signed-off-by: Ujjwal Agarwal <ujjwalcoding012@gmail.com>
Signed-off-by: Ujjwal Agarwal <ujjwalcoding012@gmail.com>
Signed-off-by: Ujjwal Agarwal <ujjwalcoding012@gmail.com>
[GSoC'21] Pr:5 . Complete the JSON saver
Signed-off-by: Ujjwal Agarwal <ujjwalcoding012@gmail.com>
- Unit Tests fro creation info function Signed-off-by: Ujjwal Agarwal <ujjwalcoding012@gmail.com>
- Write units tests for render functions for snippets ,packages , files , reviews , relationships ,annotations Signed-off-by: Ujjwal Agarwal <ujjwalcoding012@gmail.com>
- Checksums algorithm had to be parsed to string from spdx.ChecksumAlgorithm Signed-off-by: Ujjwal Agarwal <ujjwalcoding012@gmail.com>
- added test to renderfile function - added tests to renderrelationships function Signed-off-by: Ujjwal Agarwal <ujjwalcoding012@gmail.com>
Signed-off-by: Ujjwal Agarwal <ujjwalcoding012@gmail.com>
Signed-off-by: Ujjwal Agarwal <ujjwalcoding012@gmail.com>
- Check whether an entire spdx document is saved correctly or not Signed-off-by: Ujjwal Agarwal <ujjwalcoding012@gmail.com>
Signed-off-by: Ujjwal Agarwal <ujjwalcoding012@gmail.com>
…tions Signed-off-by: Ujjwal Agarwal <ujjwalcoding012@gmail.com>
…xamples - bug fixes in json saver done as well - test covereage of jsonparser increased Signed-off-by: Ujjwal Agarwal <ujjwalcoding012@gmail.com>
[GSoC'21] Pr:6 . JSON saver tests
- bug fix : sort maos keys and then range over keys instead of maps - to maintain order while savings properties as maps Signed-off-by: Ujjwal Agarwal <ujjwalcoding012@gmail.com>
Signed-off-by: Ujjwal Agarwal <ujjwalcoding012@gmail.com>
[GSoC'21] Pr:7 . JSON saver bug fix
Signed-off-by: Ujjwal Agarwal <ujjwalcoding012@gmail.com>
… original document Signed-off-by: Ujjwal Agarwal <ujjwalcoding012@gmail.com>
Signed-off-by: Ujjwal Agarwal <ujjwalcoding012@gmail.com>
[GSoC'21] Pr:8 . JSON saver bug fixes and Documentation enhancements
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This merges the GSoC work by @specter25 into the main branch in anticipation of the upcoming 0.3.0 release. Thank you @specter25 for all your hard work, and apologies that I was delayed in merging it!
This will enable saving SPDX JSON 2.2 documents from the SPDX tools-golang in-memory data model.
There are still a couple of bugs I'd like to chase down before releasing 0.3.0 (see #103), but this should be ready for others to kick the tires and see if you're finding other issues.