Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pulling main branch for code coverage #112

Merged
merged 1 commit into from Mar 13, 2022

Conversation

swinslow
Copy link
Member

After the branch renaming from 'master' to 'main' in 0.2.0 per #69,
the tests were being run by GitHub Actions on the 'main' branch.
However, the code coverage tooling appears to still have been
pulling the old 'master' branch and therefore was not including
later changes such as the new JSON code. This PR fixes this by
changing the branch name in the GitHub Actions config file.

Signed-off-by: Steve Winslow steve@swinslow.net

After the branch renaming from 'master' to 'main' in 0.2.0 per spdx#69,
the tests were being run by GitHub Actions on the 'main' branch.
However, the code coverage tooling appears to still have been
pulling the old 'master' branch and therefore was not including
later changes such as the new JSON code. This PR fixes this by
changing the branch name in the GitHub Actions config file.

Signed-off-by: Steve Winslow <steve@swinslow.net>
@swinslow swinslow self-assigned this Mar 13, 2022
@swinslow swinslow added the bug Something isn't working label Mar 13, 2022
@swinslow swinslow added this to the 0.3.0 milestone Mar 13, 2022
@swinslow swinslow merged commit 82fa7c1 into spdx:main Mar 13, 2022
@swinslow swinslow deleted the fix-codecov-badge branch March 13, 2022 17:08
@swinslow
Copy link
Member Author

swinslow commented Mar 13, 2022

Note for future reference: It looks like the change that was needed was going into https://coveralls.io/github/spdx/tools-golang/settings and re-syncing with GitHub to pull the updated default branch info. Still, this PR's change was worth making anyway :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant