[GSoC'21] Pr:5 . Complete the JSON saver #92
Conversation
- Shows error if a Package has a missing SPDXID tag - Show error if a File has a missing SPDXID tag Signed-off-by: specter25 <ujjwalcoding012@gmail.com>
- Shows error if a Package has a missing SPDXID tag - Show error if a File has a missing SPDXID tag Signed-off-by: specter25 <ujjwalcoding012@gmail.com>
- Fix capitalized initials of error messages - Other structural changes to increase code efficiency Signed-off-by: specter25 <ujjwalcoding012@gmail.com>
-- Added file name display in error messages - Structured the tests in respective files Signed-off-by: specter25 <ujjwalcoding012@gmail.com>
Signed-off-by: specter25 <ujjwalcoding012@gmail.com>
Signed-off-by: Steve Winslow <steve@swinslow.net>
Fix statement about docs license
Signed-off-by: Ian Ling <ian@iancaling.com>
Add relationship filter function
Merge JSON parsing into main
Signed-off-by: Steve Winslow <steve@swinslow.net>
Throw error for pkgs / files without SPDX IDs
Signed-off-by: Steve Winslow <steve@swinslow.net>
Fix missing colon for excludes in PackageVerificationCode
Signed-off-by: Steve Winslow <steve@swinslow.net>
Fix multi-line text wrapping fields
Signed-off-by: Steve Winslow <steve@swinslow.net>
Signed-off-by: Steve Winslow <steve@swinslow.net>
Signed-off-by: Steve Winslow <steve@swinslow.net>
Update documentation for 0.2.0 release
Signed-off-by: Steve Winslow <steve@swinslow.net>
Fix link to release notes
Signed-off-by: Ujjwal Agarwal <ujjwalcoding012@gmail.com>
- parsed other licenses from spdx.Doxument2_2 to json - tests pending Signed-off-by: Ujjwal Agarwal <ujjwalcoding012@gmail.com>
- Saved annoations on the root document from struct to json - unit tests pending Signed-off-by: Ujjwal Agarwal <ujjwalcoding012@gmail.com>
- Saved document describes from spdxStruct to json - unit tests pending from this section Signed-off-by: Ujjwal Agarwal <ujjwalcoding012@gmail.com>
- saved packages from spdx struct to json - saved relationships froms spdx struct to json Signed-off-by: Ujjwal Agarwal <ujjwalcoding012@gmail.com>
- parsed files information from struct to json - unckaged files spdx map altered (find a fix around it ) Signed-off-by: Ujjwal Agarwal <ujjwalcoding012@gmail.com>
- save snippets information from spdx struct to json - unit tests for render function pending Signed-off-by: Ujjwal Agarwal <ujjwalcoding012@gmail.com>
Signed-off-by: Ujjwal Agarwal <ujjwalcoding012@gmail.com>
- Write bytes from bytes.buffer to io.Writer while parsing json Signed-off-by: Ujjwal Agarwal <ujjwalcoding012@gmail.com>
- Parse a jsonsaved file using jsonloader and fixx the bugs discovered Signed-off-by: Ujjwal Agarwal <ujjwalcoding012@gmail.com>
- Don't remove () suffix while parsing creator person and organization Signed-off-by: Ujjwal Agarwal <ujjwalcoding012@gmail.com>
Signed-off-by: Ujjwal Agarwal <ujjwalcoding012@gmail.com>
|
@swinslow the main and json branch were not in sync after the release as a result some extra commits have come in the pull request . The commits for the jsonsaver have 'jsonsaver:' as the prefix in the commit message . |
There was a problem hiding this comment.
Hi @specter25, great job as always with this :) I've included a handful of comments below. Some of these are things we discussed yesterday so you can ignore if they are no longer applicable based on what we talked about.
I'll go ahead and merge this into the json branch so that you can keep moving forward, so feel free to review the edits at your leisure for subsequent commits. Thanks!
| if ci.Created != "" { | ||
| fmt.Fprintf(buf, "\"%s\": \"%s\",", "created", ci.Created) | ||
| } | ||
| if ci.CreatorPersons != nil || ci.CreatorOrganizations != nil || ci.CreatorTools != nil { |
There was a problem hiding this comment.
I haven't checked to confirm, but: this looks like it will run the range action across each of the CreatorPersons, CreatorOrganizations and CreatorTools slices if any one of them is non-nil.
Will this work as expected if one of them is non-nil, but the others are nil? It might be fine, I'm just forgetting at the moment whether range on a nil slice will crash, or whether it will just silently skip it.
GSoC'2021 Pull Request 5 :
Deliverables Completed :