Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i18n .since() #110

Open
david-potgieter opened this issue Mar 18, 2019 · 5 comments
Open

i18n .since() #110

david-potgieter opened this issue Mar 18, 2019 · 5 comments

Comments

@david-potgieter
Copy link

david-potgieter commented Mar 18, 2019

Seems like the since method's output is hardcoded to English?

rounded += ' ago';

Any thoughts on allowing i18n as per the custom languages example?

@david-potgieter david-potgieter changed the title Since method not i18n friendly (other methods too?) Since method not i18n friendly (other methods too?) Mar 18, 2019
@spencermountain
Copy link
Owner

fair point - yeah I like that idea.

i'm not sure it would be as easy as rounded+= variableWord,

maybe it would need to be a function? I presume there's all sorts of cultural/lingustic gotchas

rounded=i18nSince(rounded)

open to PRs

@david-potgieter
Copy link
Author

Righteo, will take a stab at it this weekend! 🤘

@spencermountain spencermountain changed the title Since method not i18n friendly (other methods too?) i18n .since() Mar 27, 2019
@marccuesta99
Copy link
Contributor

Is there any intention to move forward with this issue? Otherwise, we would be happy to present a solution.

We look forward to hearing from you, thank you very much

@spencermountain
Copy link
Owner

Hey Marc, I'm all ears! Feel free to take a crack at it. I don't know what linguistic considerations there are, but it should just involve moving the values through. Thanks for your help
Cheers

@marccuesta99
Copy link
Contributor

PR opened!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants