fix: don't remove flag value that matches subcommand name #1781
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brianpursley
commented
Aug 29, 2022
Closed
umarcor
reviewed
Sep 14, 2022
jpmcb
reviewed
Sep 29, 2022
|
any update? |
I don't think there are any outstanding questions or changes requested, so it waiting on further review or approval. |
|
@brianpursley Thanks for your reply. I'm waiting for this PR. |
marckhouzam
requested changes
Nov 8, 2022
There was a problem hiding this comment.
This looks correct to me and I think it is safe with respect to backwards-compatibility.
It will fix the broken case, which I don't see anyone expecting to work as it does now.
Since this PR requires a small rebase, I allowed myself to add two nits that hopefully @brianpursley won't mind addressing at the same time.
Thanks for your patience.
marckhouzam
added
kind/bug
When the command searches args to find the arg matching a particular subcommand name, it needs to ignore flag values, as it is possible that the value for a flag might match the name of the sub command. This change improves argsMinusFirstX() to ignore flag values when it searches for the X to exclude from the result.
brianpursley
force-pushed
the
cobra-1777
branch
from
bdbdf95
to
b9dae33
Compare
marckhouzam
approved these changes
Nov 8, 2022
marckhouzam
added
the
lgtm
|
@marckhouzam please milestone this! |
This was already milestoned 🙂 |
hoshsadiq
pushed a commit
to zulucmd/zulu
that referenced
this pull request
May 16, 2023
When the command searches args to find the arg matching a particular subcommand name, it needs to ignore flag values, as it is possible that the value for a flag might match the name of the sub command. This change improves argsMinusFirstX() to ignore flag values when it searches for the X to exclude from the result. Fixes spf13/cobra#1777 Merge spf13/cobra#1781
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the command searches args to find the arg matching a particular subcommand name, it needs to ignore flag values, as it is possible that the value for a flag might match the name of the sub command.
This change improves argsMinusFirstX() to ignore flag values when it searches for the X to exclude from the result.
Fixes #1777