Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update stale.yml #1863

Merged
merged 1 commit into from Nov 22, 2022
Merged

Update stale.yml #1863

merged 1 commit into from Nov 22, 2022

Conversation

enrichman
Copy link
Contributor

Fix typo

@CLAassistant
Copy link

CLAassistant commented Nov 21, 2022 •
edited

CLA assistant check
All committers have signed the CLA.

@github-actions github-actions bot added the area/github For changes to Github specific things not shipped in the library label Nov 21, 2022
marckhouzam
marckhouzam approved these changes Nov 22, 2022
View reviewed changes
Copy link
Collaborator

@marckhouzam marckhouzam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @enrichman !

@marckhouzam marckhouzam added this to the 1.7.0 milestone Nov 22, 2022
@marckhouzam
Copy link
Collaborator

The go 1.15 test is failing with

../../../go/pkg/mod/github.com/kyoh86/richgo@v0.3.11/config/load.go:64:9: undefined: os.ReadFile

Looks like richgo 0.3.11, which was released 6 days ago, requires go 1.16.
We probably need to fix the version to 0.3.10 to continue working with go 1.15

@umarcor what do you think?

Since it is unrelated to the PR I will merge anyway.

@marckhouzam marckhouzam merged commit 4305498 into spf13:main Nov 22, 2022
@enrichman
Copy link
Contributor Author

@marckhouzam you're welcome, thanks for the quick review!

@umarcor
Copy link
Contributor

umarcor commented Nov 22, 2022

@marckhouzam go 1.15 is EOL. I believe we can remove it from the CI. However, this repo has a very unclear criteria to deprecate golang versions. In theory, https://github.com/spf13/cobra/blob/main/CONDUCT.md#deprecation. In practice, it's arbitrary upon how do maintainers (or employers) feel.

@marckhouzam marckhouzam mentioned this pull request Nov 22, 2022
Closed
@marckhouzam
Copy link
Collaborator

Let's move the discussion to #1864

Repository owner locked as off-topic and limited conversation to collaborators Nov 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@marckhouzam marckhouzam marckhouzam approved these changes

Assignees
No one assigned
Labels
area/github For changes to Github specific things not shipped in the library
Projects
None yet
Milestone
1.7.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@enrichman @CLAassistant @marckhouzam @umarcor