Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No mechanism to override logger #1268

Closed
1 task done
idcmp opened this issue Dec 28, 2021 · 3 comments
Closed
1 task done

No mechanism to override logger #1268

idcmp opened this issue Dec 28, 2021 · 3 comments
Labels
kind/enhancement New feature or request

Comments

@idcmp
Copy link

idcmp commented Dec 28, 2021

Preflight Checklist

  • I have searched the issue tracker for an issue that matches the one I want to file, without success.

Problem Description

v.logger is now an interface, which is great, but there's no mechanism to override the default jwwLogger{} for the global Viper (GetViper()).

Proposed Solution

introduce a GetViper().UseLogger(newLogger Logger) ?

Alternatives Considered

No response

Additional Information

No response

@idcmp idcmp added the kind/enhancement New feature or request label Dec 28, 2021
@github-actions
Copy link

👋 Thanks for reporting!

A maintainer will take a look at your issue shortly. 👀

In the meantime: We are working on Viper v2 and we would love to hear your thoughts about what you like or don't like about Viper, so we can improve or fix those issues.

⏰ If you have a couple minutes, please take some time and share your thoughts: https://forms.gle/R6faU74qPRPAzchZ9

📣 If you've already given us your feedback, you can still help by spreading the news,
either by sharing the above link or telling people about this on Twitter:

https://twitter.com/sagikazarmark/status/1306904078967074816

Thank you! ❤️

@sagikazarmark
Copy link
Collaborator

Thanks for opening this issue @idcmp !

I opened another issue to track this as well: #1270

@sagikazarmark
Copy link
Collaborator

#1275 adds an experimental WithLogger function that allows overriding the builtin logger. Please note that it is not covered by the backwards compatibility promise.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants