Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recommend to split remote implements to multi repos #770

Closed
wyxloading opened this issue Sep 27, 2019 · 2 comments
Closed

Recommend to split remote implements to multi repos #770

wyxloading opened this issue Sep 27, 2019 · 2 comments

Comments

@wyxloading
Copy link

Now package remote stick in the viper repo, leave us many dependencies.

How about spliting those remote implements to separate repos, like viper-consul, viper-etcd. Then we could choose what we actually need.
Also contributors can write different remote implementations of their own, which should not fire as a mr to viper.

@sagikazarmark
Copy link
Collaborator

Eventually that would be nice, but for v1 we can't really remove those dependencies without breaking BC.

Since the package now uses go modules, we could make the remote package a separate module.

@wyxloading
Copy link
Author

see #772

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants