Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

just a little code style question #939

Closed
hoojos opened this issue Jul 27, 2020 · 2 comments · Fixed by #1458
Closed

just a little code style question #939

hoojos opened this issue Jul 27, 2020 · 2 comments · Fixed by #1458
Milestone
v1.14.0

Comments

@hoojos
Copy link

hoojos commented Jul 27, 2020

tag: v1.7.0
filename: viper.go
line: 388

Question: It looks like include a surplus bit operation : event.Op&fsnotify.Remove&fsnotify.Remove != 0, event.Op&fsnotify.Remove != 0 is ok
@arp242
Copy link

arp242 commented Nov 3, 2022

This got fixed in #1250 – and with #1458 the new Has() method is used.

This can be closed @sagikazarmark

@sagikazarmark
Copy link
Collaborator

Thanks @arp242

@sagikazarmark sagikazarmark mentioned this issue Nov 3, 2022
Merged
@sagikazarmark sagikazarmark added this to the v1.14.0 milestone Nov 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.14.0
Development

Successfully merging a pull request may close this issue.

Fsnotify improvements spf13/viper
3 participants
@arp242 @sagikazarmark @hoojos