Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding some video block attributes #29

Open
Borda opened this issue Jun 28, 2023 · 1 comment
Open

adding some video block attributes #29

Borda opened this issue Jun 28, 2023 · 1 comment

Comments

@Borda
Copy link
Contributor

Borda commented Jun 28, 2023

Would it be possible to add some extra attributes to the video block, for example, we are using:

<video 
	width="50%"
	max-width="400px"
	controls
	poster="https://pl-bolts-doc-images.s3.us-east-2.amazonaws.com/pl_docs/trainer_flags/thumb/check_val_every_n_epoch.jpg"
	src="https://pl-bolts-doc-images.s3.us-east-2.amazonaws.com/pl_docs/trainer_flags/check_val_every_n_epoch.mp4"
></video>

as this is not obvious from the readme and it would help us with Lightning-AI/pytorch-lightning#17941 (comment)

@Borda
Copy link
Contributor Author

Borda commented Jun 28, 2023

UPDATE: it seems most of them are there:

SUPPORTED_OPTIONS: List[str] = [

so maybe just update the readme with a rich example?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant