From 13011703ea5e06b5955263281ec8cf5797cf4f9a Mon Sep 17 00:00:00 2001 From: Takeshi KOMIYA Date: Mon, 24 Jan 2022 02:22:31 +0900 Subject: [PATCH] Fix #10122: make.bat should check the installation before help --- CHANGES | 2 ++ sphinx/templates/quickstart/make.bat.new_t | 4 ++-- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/CHANGES b/CHANGES index e243770e24a..e01925377bd 100644 --- a/CHANGES +++ b/CHANGES @@ -21,6 +21,8 @@ Bugs fixed ---------- * #10133: autodoc: Crashed when mocked module is used for type annotation +* #10122: sphinx-build: make.bat does not check the installation of sphinx-build + command before showing help Testing -------- diff --git a/sphinx/templates/quickstart/make.bat.new_t b/sphinx/templates/quickstart/make.bat.new_t index ab30130c97a..c89237ba2e2 100644 --- a/sphinx/templates/quickstart/make.bat.new_t +++ b/sphinx/templates/quickstart/make.bat.new_t @@ -10,8 +10,6 @@ if "%SPHINXBUILD%" == "" ( set SOURCEDIR={{ rsrcdir }} set BUILDDIR={{ rbuilddir }} -if "%1" == "" goto help - %SPHINXBUILD% >NUL 2>NUL if errorlevel 9009 ( echo. @@ -25,6 +23,8 @@ if errorlevel 9009 ( exit /b 1 ) +if "%1" == "" goto help + %SPHINXBUILD% -M %1 %SOURCEDIR% %BUILDDIR% %SPHINXOPTS% %O% goto end