Reduce body_min_width in basic theme
#10197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tk0miya
reviewed
Feb 19, 2022
sphinx/themes/basic/theme.conf
Outdated
| @@ -7,7 +7,7 @@ sidebars = localtoc.html, relations.html, sourcelink.html, searchbox.html | |||
| [options] | |||
| nosidebar = false | |||
| sidebarwidth = 230 | |||
| body_min_width = 450 | |||
| body_min_width = 300 | |||
There was a problem hiding this comment.
Is any reason to choose this value?
I just searched the screensizes of well-used mobile devices. Some reports says 360px is smallest size at present.
https://www.browserstack.com/guide/ideal-screen-sizes-for-responsive-design
https://mediag.com/blog/popular-screen-resolutions-designing-for-all/
There was a problem hiding this comment.
I picked it because it solved the bug. Another value could work fine if it also resolve the issue.
Some reports says 360px is smallest size at present. refs: - https://www.browserstack.com/guide/ideal-screen-sizes-for-responsive-design - https://mediag.com/blog/popular-screen-resolutions-designing-for-all/
|
I determined to use 360px for the new default value of |
|
Merged. Thank you for your contribution! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current 450px setting is too large for many small device width. It causes x-overflows that make the page appear broken and introduces difficulty reading on many phones.