Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[C++] Support attributes on class and union and improve formatting #10252

Merged
merged 12 commits into from
Mar 12, 2022
Merged

[C++] Support attributes on class and union and improve formatting #10252

merged 12 commits into from
Mar 12, 2022
+62 −11

Conversation

jbms
Copy link
Contributor

@jbms jbms commented Mar 11, 2022

Feature or Bugfix

  • Feature

Purpose

This allows classes and unions to be declared with attributes.

This also adds more semantic elements to the generated signature for C++ attributes to improve the formatting.

@jbms
[C++] Support attributes on class and union and improve formatting

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
670e8b1
jakobandersen
jakobandersen requested changes Mar 11, 2022
View reviewed changes
Copy link
Contributor

@jakobandersen jakobandersen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice, thanks! Aside from the marked changes it looks really good.

jbms and others added 10 commits March 11, 2022 05:02
@jbms @jakobandersen
Update sphinx/domains/cpp.py
1dd0220 
Co-authored-by: Jakob Lykke Andersen <jakobandersen@users.noreply.github.com>
@jbms @jakobandersen
Update sphinx/domains/cpp.py
619d817 
Co-authored-by: Jakob Lykke Andersen <jakobandersen@users.noreply.github.com>
@jbms @jakobandersen
Update sphinx/domains/cpp.py
6073b32 
Co-authored-by: Jakob Lykke Andersen <jakobandersen@users.noreply.github.com>
@jbms @jakobandersen
Update sphinx/domains/cpp.py
0cb021b 
Co-authored-by: Jakob Lykke Andersen <jakobandersen@users.noreply.github.com>
@jbms @jakobandersen
Update sphinx/domains/cpp.py
8aa785f 
Co-authored-by: Jakob Lykke Andersen <jakobandersen@users.noreply.github.com>
@jbms @jakobandersen
Update sphinx/util/cfamily.py
f327757 
Co-authored-by: Jakob Lykke Andersen <jakobandersen@users.noreply.github.com>
@jbms @jakobandersen
Update sphinx/util/cfamily.py
2307e9f 
Co-authored-by: Jakob Lykke Andersen <jakobandersen@users.noreply.github.com>
@jbms @jakobandersen
Update tests/test_domain_cpp.py
ce82f9e 
Co-authored-by: Jakob Lykke Andersen <jakobandersen@users.noreply.github.com>
@jbms @jakobandersen
Update tests/test_domain_cpp.py
2c1e4c4 
Co-authored-by: Jakob Lykke Andersen <jakobandersen@users.noreply.github.com>
@jbms @jakobandersen
Update tests/test_domain_cpp.py
a9a5cec 
Co-authored-by: Jakob Lykke Andersen <jakobandersen@users.noreply.github.com>
@jbms jbms requested a review from jakobandersen March 11, 2022 13:03
@jbms @jakobandersen
Update sphinx/domains/cpp.py
Loading
Loading status checks…
926fab0 
Co-authored-by: Jakob Lykke Andersen <jakobandersen@users.noreply.github.com>
jakobandersen added a commit to jakobandersen/sphinx that referenced this pull request Mar 12, 2022
@jakobandersen
Update changes for merging sphinx-doc#10252
5a8ce35
@jakobandersen jakobandersen merged commit 926fab0 into sphinx-doc:4.x Mar 12, 2022
@jakobandersen jakobandersen added this to the 4.5.0 milestone Mar 12, 2022
@jakobandersen
Copy link
Contributor

Great, thanks!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jakobandersen jakobandersen

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.5.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jbms @jakobandersen