Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[C++] Support attributes on class and union and improve formatting #10252

Merged
merged 12 commits into from Mar 12, 2022

Conversation

jbms
Copy link
Contributor

@jbms jbms commented Mar 11, 2022

Feature or Bugfix

  • Feature

Purpose

This allows classes and unions to be declared with attributes.

This also adds more semantic elements to the generated signature for C++ attributes to improve the formatting.

Copy link
Contributor

@jakobandersen jakobandersen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice, thanks! Aside from the marked changes it looks really good.

sphinx/domains/cpp.py Outdated Show resolved Hide resolved
sphinx/domains/cpp.py Outdated Show resolved Hide resolved
sphinx/domains/cpp.py Outdated Show resolved Hide resolved
sphinx/domains/cpp.py Outdated Show resolved Hide resolved
sphinx/domains/cpp.py Outdated Show resolved Hide resolved
sphinx/util/cfamily.py Outdated Show resolved Hide resolved
sphinx/util/cfamily.py Outdated Show resolved Hide resolved
tests/test_domain_cpp.py Outdated Show resolved Hide resolved
tests/test_domain_cpp.py Outdated Show resolved Hide resolved
tests/test_domain_cpp.py Outdated Show resolved Hide resolved
jbms and others added 10 commits March 11, 2022 05:02
Co-authored-by: Jakob Lykke Andersen <jakobandersen@users.noreply.github.com>
Co-authored-by: Jakob Lykke Andersen <jakobandersen@users.noreply.github.com>
Co-authored-by: Jakob Lykke Andersen <jakobandersen@users.noreply.github.com>
Co-authored-by: Jakob Lykke Andersen <jakobandersen@users.noreply.github.com>
Co-authored-by: Jakob Lykke Andersen <jakobandersen@users.noreply.github.com>
Co-authored-by: Jakob Lykke Andersen <jakobandersen@users.noreply.github.com>
Co-authored-by: Jakob Lykke Andersen <jakobandersen@users.noreply.github.com>
Co-authored-by: Jakob Lykke Andersen <jakobandersen@users.noreply.github.com>
Co-authored-by: Jakob Lykke Andersen <jakobandersen@users.noreply.github.com>
Co-authored-by: Jakob Lykke Andersen <jakobandersen@users.noreply.github.com>
@jbms jbms requested a review from jakobandersen March 11, 2022 13:03
Co-authored-by: Jakob Lykke Andersen <jakobandersen@users.noreply.github.com>
jakobandersen added a commit to jakobandersen/sphinx that referenced this pull request Mar 12, 2022
@jakobandersen jakobandersen merged commit 926fab0 into sphinx-doc:4.x Mar 12, 2022
@jakobandersen jakobandersen added this to the 4.5.0 milestone Mar 12, 2022
@jakobandersen
Copy link
Contributor

Great, thanks!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants