Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

C++, conditional expression (update of #10270) #10302

Merged
merged 6 commits into from Apr 17, 2022
Merged

C++, conditional expression (update of #10270) #10302

merged 6 commits into from Apr 17, 2022

Conversation

jakobandersen
Copy link
Contributor

@jakobandersen jakobandersen commented Mar 27, 2022 •
edited

Completion of #10270.

Note: env bumping was done earlier in 4.x so it's not needed here.

@jakobandersen jakobandersen added type:enhancement enhance or introduce a new feature domains:cpp labels Mar 27, 2022
@jakobandersen jakobandersen self-assigned this Mar 27, 2022
@jakobandersen jakobandersen modified the milestones: 4.5.0, 5.0.0 Mar 27, 2022
@jbms
Copy link
Contributor

jbms commented Mar 29, 2022

Thanks for your revisions --- this looks good to me.

@jakobandersen jakobandersen changed the base branch from 4.x to master March 31, 2022 19:10
@jakobandersen jakobandersen changed the base branch from master to 5.x April 17, 2022 12:23
@jakobandersen jakobandersen merged commit d951e55 into sphinx-doc:5.x Apr 17, 2022
@jakobandersen jakobandersen deleted the cpp_cond_expr branch April 17, 2022 12:32
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@jakobandersen jakobandersen

Labels
domains:cpp type:enhancement enhance or introduce a new feature
Projects
None yet
Milestone
5.0.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jakobandersen @jbms