Fix parsing of options with enabled option_emphasise_placeholders #10565
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you add a test to ensure this behaviour doesn't regress? A |
marxin
force-pushed
the
fix-parsing-with-option_emphasise_placeholders
branch
3 times, most recently
from
234b559
to
248ae64
Compare
Sure, I've just done that. |
|
It seems conflicted. Could you check it please? |
If the option is enabled, the current code wrongly uses if not args: continue which skips adjustment of signode and firstname at the very of the loop. Fixes: sphinx-doc#10366.
marxin
force-pushed
the
fix-parsing-with-option_emphasise_placeholders
branch
from
248ae64
to
664d9df
Compare
Sure, the conflicts are resolved now. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the option is enabled, the current code wrongly uses
which skips adjustement of signode and firstname
at the very of the loop.
Fixes: #10366.