Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix usage of enable_search_shortcuts theme config value. #10566

Merged
merged 1 commit into from Jun 19, 2022

Conversation

marxin
Copy link
Contributor

@marxin marxin commented Jun 17, 2022

The option value is not properly propagated to Java script.

I've just tested that locally with value unset in config and set to False and True in html_theme_options.

@AA-Turner
Copy link
Member

Can you add a test to ensure this behaviour doesn't regress?

A

The option value is not properly propagated to Java script.
@marxin
Copy link
Contributor Author

marxin commented Jun 17, 2022

Can you add a test to ensure this behaviour doesn't regress?

Sure, the tests are added.

@tk0miya
Copy link
Member

tk0miya commented Jun 19, 2022

LGTM. Thanks!

@tk0miya tk0miya closed this Jun 19, 2022
@tk0miya tk0miya reopened this Jun 19, 2022
@tk0miya tk0miya merged commit 95b8183 into sphinx-doc:5.x Jun 19, 2022
tk0miya added a commit that referenced this pull request Jun 19, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 20, 2022
@marxin marxin deleted the fix-theme-config-usage branch September 9, 2022 10:29
@AA-Turner AA-Turner modified the milestones: 5.x, 5.1.0 Oct 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants