Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

5.2.0 release plan #10853

Closed
AA-Turner opened this issue Sep 23, 2022 · 8 comments
Closed

5.2.0 release plan #10853

AA-Turner opened this issue Sep 23, 2022 · 8 comments
Assignees
Milestone

Comments

@AA-Turner
Copy link
Member

I intend to release Sphinx 5.2.0 tomorrow (Saturday), 24/09/22.

Issues marked against 5.2.0: https://github.com/sphinx-doc/sphinx/milestone/130

Please alert me to any PRs/issues that should be included in 5.2.0.

A

@AA-Turner AA-Turner added this to the 5.2.0 milestone Sep 23, 2022
@AA-Turner AA-Turner self-assigned this Sep 23, 2022
@AA-Turner AA-Turner pinned this issue Sep 23, 2022
@mgeier
Copy link
Contributor

mgeier commented Sep 23, 2022

Can you please include #10692 in the release?

@jfbu
Copy link
Contributor

jfbu commented Sep 24, 2022

@AA-Turner somehow I got not pinged from this issue creation (I do not watch all issue creations by default) so it is probably too late to consider merge of #10759. I did merge 5.x into it, so it is merge ready. Now, @tk0miya did not have time to review it so we can indeed delay to next one.

@AA-Turner
Copy link
Member Author

Sphinx 5.2.0 has been released, thanks to all for your support and contributions.

A

@eandersson
Copy link

Is it intended that two versions were released?

5.2.0
5.2.0.post0

@AA-Turner
Copy link
Member Author

Yes, see #10714 (comment)

A

@rkdarst
Copy link
Contributor

rkdarst commented Sep 25, 2022

FYI, the .post0 has caused a breakage in sphinx_rtd_theme, because it assumes that the sphinx version number has only three components separated by . (a, b, c = version.split('.')):

This is a problem in sphinx_rtd_theme, not sphinx (since .post0 is a documented version number). But, sphinx_rtd_theme is very commonly used and releases slowly, so there will probably be many projects needing to work around this.

If sphinx_rtd_theme doesn't release soon, the best "solution" is probably waiting for Sphinx to release again.

This is my personal workaround, which seems like it is being used by others as well:

sphinx!=5.2.0.post0    # remove after next release

@AA-Turner
Copy link
Member Author

Sphinx 5.2.1 has been released.

A

@rkdarst
Copy link
Contributor

rkdarst commented Sep 25, 2022

Thank you! (on behalf of many sphinx users)
This, but also all of your general work on Sphinx.

@AA-Turner AA-Turner unpinned this issue Sep 28, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants