Remove support for parsing pre-v3 syntax in the C domain #10901
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AA-Turner
commented
Oct 6, 2022
| msg = "{}: Pre-v3 C type directive '.. c:type:: {}' converted to " \ | ||
| "'.. c:{}:: {}'." \ | ||
| "\nThe original parsing error was:\n{}" | ||
| msg = msg.format(RemovedInSphinx70Warning.__name__, |
There was a problem hiding this comment.
Note this was bumped to 70 per request in #10471 (comment), though no version was ever published with the delay in deprecation so we are still OK to remove in 6.0.
A
AA-Turner
force-pushed
the
remove-pre-v3
branch
from
2c21f5b
to
cc00b30
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the completion of python/cpython#93738, we are now free to remove support for pre-v3 syntax in the C domain. Note previously we had confirmed the Linux kernel does not require the variable either (#10471 (comment), https://lore.kernel.org/linux-doc/LO3P123MB26810D190462B6BBBF1305F6C2A19@LO3P123MB2681.GBRP123.PROD.OUTLOOK.COM/T/#u).
cc: @jakobandersen
A