Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore correct parallel search index building #11192

Merged
merged 2 commits into from Feb 15, 2023

Conversation

jbms
Copy link
Contributor

@jbms jbms commented Feb 12, 2023

Feature or Bugfix

  • Bugfix

Purpose

Reverts the remaining changes from b32841e.

The image-related changes were already reverted in 2a7c40d, but the search index changes also need to be reverted.

It would be nice to support parallel search index building, but the necessary support for merging the search indices produced by each process needs to be added first.

Fixes #11163.

@jbms jbms changed the title Revert b32841e153431ec02de31e9ec32e79ab3ac7d1c2 to fix parallel search index building Revert broken parallel search index building Feb 12, 2023
The image-related changes were already reverted in
2a7c40d, but the search index changes
also need to be reverted.

It would be nice to support parallel search index building, but the
necessary support for merging the search indices produced by each
process needs to be added first.

Fixes sphinx-doc#11163.
@AA-Turner AA-Turner changed the title Revert broken parallel search index building Restore parallel search index building Feb 15, 2023
@AA-Turner AA-Turner changed the title Restore parallel search index building Restore correct parallel search index building Feb 15, 2023
@AA-Turner AA-Turner merged commit 44684e1 into sphinx-doc:master Feb 15, 2023
@jbms jbms deleted the fix-11163 branch February 15, 2023 05:26
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 18, 2023
@AA-Turner AA-Turner added this to the 6.2.0 milestone Apr 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Smaller/wrong search index with sphinx-build -j auto
2 participants