-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HTMLHELP Relative URL strings must not have a query component #11889
Comments
Hi @mkay-sh, A PR would be appreciated, thank you! A |
Do you have any notes about the introduction of the CRC32 checksums @AA-Turner? I'm guessing it may have been to help cache-bust CSS/JS retrieval? |
For exactly that reason, yes. A |
Ok - and is/was it not possible to use |
(my honest opinion is that I feel like this should be solved by ETags (for content caching) and subresource integrity (content integrity validation) - but I don't know how reliable those are at scale, especially for legacy/speciality user agents) |
Describe the bug
With the implementation of #11415 checksums are added to css file links in the html output. But in the htmlhelp output format the windows help viewer fails to load the stylesheets. If I remove the query component before compiling the chm file it works.
How to Reproduce
Environment Information
Additional context
It's a similar issue to #11598 where it does not work with epub.
I can provide a pull request to fix this if you are interested.
The text was updated successfully, but these errors were encountered: