Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

C domain: Fix namespace-pop context #11935

Merged
merged 1 commit into from Feb 3, 2024

Conversation

ferdnyc
Copy link
Contributor

@ferdnyc ferdnyc commented Feb 3, 2024

The ref_context key is c:parent_key, not cp:parent_key.

Subject: Correct a ref_context key in CNamespacePop

Feature or Bugfix

  • Bugfix

Purpose

  • Correct a ref_context item named cp:parent_key, which the CNamespacePop directive was seetting when restoring the context.

Detail

  • The erroneous key here was the only instance in the entire codebase of that name being used. All others are c:parent_key.
  • This appears to have likely been a typo, made when converting the code from the C++ domain and editing the key down from cpp:parent_key.

The ref_context key is `c:parent_key`, not `cp:parent_key`.
@ferdnyc
Copy link
Contributor Author

ferdnyc commented Feb 3, 2024

A Windows failure, once again, in the unrelated test tests/test_intl/test_intl.py::test_gettext_dont_rebuild_mo.

@AA-Turner AA-Turner merged commit 9faf114 into sphinx-doc:master Feb 3, 2024
21 of 22 checks passed
@ferdnyc ferdnyc deleted the fix-c-namespacepop branch February 4, 2024 02:00
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants