Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reimplement parallel build feature #6881

Open
tk0miya opened this issue Dec 1, 2019 · 6 comments
Open

Reimplement parallel build feature #6881

tk0miya opened this issue Dec 1, 2019 · 6 comments
Labels
internals:parallel type:enhancement enhance or introduce a new feature

Comments

@tk0miya
Copy link
Member

tk0miya commented Dec 1, 2019

Is your feature request related to a problem? Please describe.
For now, parallel build does not support Windows platform. Addition to this, it will be disabled soon on macOS and py38+ for security reasons (see #6803 and #6879).
So it would be nice if we'll reimplement the parallel build to support these platform.

Describe the solution you'd like
Reimplement it with "spawn" process model.

Describe alternatives you've considered
N/A

@russellballestrini
Copy link

@tk0miya Does parallel builds still work with Linux? What about Linux running py38+?

@tk0miya
Copy link
Member Author

tk0miya commented Nov 19, 2020

@russellballestrini It is still available. Please let me know if not.

@russellballestrini
Copy link

russellballestrini commented Nov 19, 2020

Thank you, I'll test today. I'm working on a project that has 16,000+ documents (huge dataset, I know, so I'll be building my "data pipeline" via docker and linux). I'm leaning hard on the built in javascript index for finding documents quickly without needing a server. Seems to work (with a minor question I raised in the mailing address regarding how to customize the tokenizer)

@Blendify
Copy link
Contributor

Any updates on this? This is a major problem for projects with a large number of files.

@tk0miya
Copy link
Member Author

tk0miya commented Mar 18, 2021

Nothing improved. It's a chance to contribute! Any PR on this?

@pradyunsg
Copy link
Contributor

pradyunsg commented Jan 8, 2022

it will be disabled soon on macOS and py38+ for security reasons (see #6803 and #6879).

With #9793, MacOS and py38+ can now use the fork model as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internals:parallel type:enhancement enhance or introduce a new feature
Projects
None yet
Development

No branches or pull requests

5 participants