Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ImgConverter runs is_available in HTML builder #7973

Closed
Daltz333 opened this issue Jul 18, 2020 · 3 comments
Closed

ImgConverter runs is_available in HTML builder #7973

Daltz333 opened this issue Jul 18, 2020 · 3 comments
Labels
extensions type:bug
Milestone
3.3.0

Comments

@Daltz333
Copy link

Since ImgConverter is only used in the LaTeX builder, this check should not happen in HTML.
@tk0miya
Copy link
Member

tk0miya commented Jul 18, 2020

Why do you think so? It is available for all of the builders. For example, it converts PDF image to an appropriate format for
HTML builder. The extension is not only for the LaTeX builder, I think.

@Daltz333
Copy link
Author

I use the svg2pdf-converter extension which is based on the ImageConverter class. Currently on windows it throws 150+ errors (one per document) because of missing dependencies. Since we only build PDF on latex we were hoping using the extension wouldn't be a problem.

@tk0miya
Copy link
Member

tk0miya commented Jul 18, 2020

I understand. I agreed that so many warnings are meaningless and noisy. It would be better to emit only one warning during the build (Note: I don't think to suppress all of the warnings is better).

@tk0miya tk0miya added this to the 3.2.0 milestone Jul 18, 2020
tk0miya added a commit to tk0miya/sphinx that referenced this issue Jul 18, 2020
@tk0miya
Fix sphinx-doc#7973: imgconverter: Check availability of imagemagick …
97524d3 
…many times
tk0miya added a commit to tk0miya/sphinx that referenced this issue Jul 18, 2020
@tk0miya
Fix sphinx-doc#7973: imgconverter: Check availability of imagemagick …
e5a34e3 
…many times
tk0miya added a commit to tk0miya/sphinx that referenced this issue Jul 18, 2020
@tk0miya
Fix sphinx-doc#7973: imgconverter: Check availability of imagemagick …
ca9d0f6 
…many times

To prevent checking the availability of image converters times and times
again, this stores the result to the class variable.  It is not a good
design to have a state globally.  So this should be refactored in the
future.
@tk0miya tk0miya mentioned this issue Jul 18, 2020
Merged
@tk0miya tk0miya modified the milestones: 3.2.0, 3.3.0 Aug 7, 2020
tk0miya added a commit to tk0miya/sphinx that referenced this issue Oct 4, 2020
@tk0miya
Fix sphinx-doc#7973: imgconverter: Check availability of imagemagick …
50dd613 
…many times

To prevent checking the availability of image converters times and times
again, this stores the result to the class variable.  It is not a good
design to have a state globally.  So this should be refactored in the
future.
@tk0miya tk0miya closed this as completed in 4571797 Oct 4, 2020
tk0miya added a commit that referenced this issue Oct 4, 2020
@tk0miya
Merge pull request #7978 from tk0miya/7973_imgconverter_warnings
f2d8093 
Fix #7973: imgconverter: Check availability of imagemagick many times
sephalon pushed a commit to sephalon/sphinx that referenced this issue Jan 4, 2021
Skip imgconverter availability check if builder supports the image type
ef23669 
Close sphinx-doc#7973: ImgConverter runs is_available in HTML builder
Close missinglinkelectronics/sphinxcontrib-svg2pdfconverter#8: Extension should only run on LaTeX builder
@sephalon sephalon mentioned this issue Jan 4, 2021
Merged
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
extensions type:bug
Projects
None yet
Milestone
3.3.0
Development

No branches or pull requests
2 participants
@tk0miya @Daltz333