add parallel to SphinxTestApp #8257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tk0miya
reviewed
Oct 1, 2020
tests/test_build_html.py
Outdated
| @@ -421,6 +421,12 @@ def test_html5_output(app, cached_etree_parse, fname, expect): | |||
| check_xpath(cached_etree_parse(app.outdir / fname), fname, *expect) | |||
|
|
|||
|
|
|||
| @pytest.mark.skipif(docutils.__version_info__ < (0, 13), | |||
| reason='docutils-0.13 or above is required') | |||
There was a problem hiding this comment.
Why are you marking this as docutils-0.13 or above only?
There was a problem hiding this comment.
I copied the example below. I don't have any understanding of why it might be needed. Should I remove it?
There was a problem hiding this comment.
Yes, please. The above and below test cases surely depends on docutils-0.13+. But this is not.
There was a problem hiding this comment.
Removed unnecessary skipif
|
Thanks! |
tk0miya
added a commit
that referenced
this pull request
Oct 1, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subject: allow parallel with SphinxTestApp
Feature or Bugfix
Purpose