Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent arrow keys changing page when button elements are focused #8316

Merged
merged 1 commit into from Oct 27, 2020

Conversation

foster999
Copy link
Contributor

Subject: Change document event listener, so that arrow keys can be used to access tabbed content

Feature or Bugfix

  • Bugfix

Purpose

  • Left and right arrow key presses trigger sphinx docs to switch the previous or next page, respectively. Left and right arrow keys may be required for keyboard-only users to access content within a page. For example, where button elements are used to switch between tabbed content. This minor change prevents the arrow keys from triggering a page change when the active element is a button, as in the case of accessible tabs. This allows users to switch accessible tabbed content using only a keyboard.

Detail

Relates

@foster999 foster999 changed the base branch from 3.x to 3.2.x October 15, 2020 08:08
@foster999 foster999 changed the base branch from 3.2.x to 3.x October 15, 2020 08:10
@tk0miya tk0miya added this to the 3.3.0 milestone Oct 27, 2020
@tk0miya tk0miya merged commit 8bd1600 into sphinx-doc:3.x Oct 27, 2020
@tk0miya
Copy link
Member

tk0miya commented Oct 27, 2020

Thank you for your contribution!

tk0miya added a commit that referenced this pull request Oct 27, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 22, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants