Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Graphviz Extension: graphviz_dot option is not replaced by layout for graph and digraph directives #8454

Closed
loebl opened this issue Nov 20, 2020 · 2 comments

Comments

@loebl
Copy link

loebl commented Nov 20, 2020

Describe the bug
A clear and concise description of what the bug is.

When adding the new layout option to class Graphviz, it was forgotten to add it to GraphvizSimple. This way the documentation and code/behaviour are not consistent

To Reproduce

Compare:

Expected behavior
Option listing (and processing) should be identical

Your project

Mini-Example:

.. works

.. graphviz::
   :layout: neato

   graph foobar {
   foo -- bar;
   bar -- baz;
   baz -- foo;
   }

.. doesn't work

.. graph::
   :layout: neato

   foo -- bar;
   bar -- baz;
   baz -- foo;

EDIT: corrected graph directive in example

Screenshots
none

Environment info

  • OS: Debian 10 (Buster), Sphinx inside virtualenv
  • Python version: 3.7.3
  • Sphinx version: 3.2.1
  • Sphinx extensions: sphinx.ext.graphviz, sphinx_rtd_theme
  • Extra tools: firefox 78.5.0

Additional context
None

@loebl
Copy link
Author

loebl commented Nov 20, 2020

👍
Thanks

tk0miya added a commit that referenced this issue Nov 20, 2020
Fix #8454: graphviz: The layout option for graph and digraph don't work
@tk0miya
Copy link
Member

tk0miya commented Nov 20, 2020

Fixed. Thank you for reporting!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants