Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

-D gettext_compact=0 is no longer working #8549

Closed
JulienPalard opened this issue Dec 17, 2020 · 1 comment
Closed

-D gettext_compact=0 is no longer working #8549

JulienPalard opened this issue Dec 17, 2020 · 1 comment
Labels
internals:internationalisation type:bug
Milestone
3.4.0

Comments

@JulienPalard
Copy link
Contributor

Describe the bug

Since #8058, using -D gettext_compact=0 to have multiple .po files does no longer works. Instead it gives a single 0.po file.

To Reproduce
Steps to reproduce the behavior:

$ git clone https://github.com/python/cpython
$ cd cpython/Doc
$ sphinx-build -b gettext -D gettext_compact=0 . ../pot
$ ls ../pot  # and see 0.po instead of one `.po` file per rst file.

Expected behavior

I expect one file per .rst file, as in https://github.com/python/python-docs-fr.

Your project

https://github.com/python/python-docs-fr

Environment info

  • OS: Debian
  • Python version: 3.9.0
  • Sphinx version: 3.3.1
tk0miya added a commit to tk0miya/sphinx that referenced this issue Dec 19, 2020
@tk0miya
Fix sphinx-doc#8549: i18n: -D gettext_compact=0 is no longer working
7fe9ec7 
Since 1bf7fe4, ``-D gettext_compact=0`` is not treated as disabling
the feature.  It is recognized as creating ``0.pot`` because its type is
Any.  This changes it to `[bool, str]`.
@tk0miya tk0miya added this to the 3.4.0 milestone Dec 19, 2020
@tk0miya tk0miya mentioned this issue Dec 19, 2020
Merged
tk0miya added a commit that referenced this issue Dec 20, 2020
@tk0miya
Merge pull request #8556 from tk0miya/8549_gettext_compact=0
723294f 
Fix #8549: i18n: ``-D gettext_compact=0`` is no longer working
@JulienPalard
Copy link
Contributor Author

Hey, thanks a lot @tk0miya! I appreciate how fast you fixed this one! Happy holidays :)

cocoatomo added a commit to python/python-docs-ja that referenced this issue Jan 21, 2021
@cocoatomo
Delete 0.po
6deb228 
The file named 0.po has been created due to the bug, that resolved.

ref. sphinx-doc/sphinx#8549
cocoatomo added a commit to python-doc-ja/cpython-doc-catalog that referenced this issue Jan 21, 2021
@cocoatomo
Delete 0.pot
921ca9f 
The file named 0.po has been created due to the bug, that resolved.

ref. sphinx-doc/sphinx#8549
@cocoatomo cocoatomo mentioned this issue Jan 21, 2021
Merged
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
internals:internationalisation type:bug
Projects
None yet
Milestone
3.4.0
Development

No branches or pull requests
2 participants
@JulienPalard @tk0miya