Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

highlight_options is not working #8671

Closed
tk0miya opened this issue Jan 10, 2021 · 0 comments
Closed

highlight_options is not working #8671

tk0miya opened this issue Jan 10, 2021 · 0 comments
Labels
Milestone

Comments

@tk0miya
Copy link
Member

tk0miya commented Jan 10, 2021

Describe the bug
highlight_options is not working

To Reproduce

# conf.py
highlight_language = 'php'
highlight_options = {'startinline': True}
# index.rst
.. code-block:: php

   echo "hello world";

.. code-block::

   echo "hello world";

But startinline option does not effect to the HTML and LaTeX output.

Expected behavior
The highlight_options works fine.

Your project
No

Screenshots
No

Environment info

  • OS: Mac
  • Python version: 3.8.3
  • Sphinx version: HEAD of 3.x
  • Sphinx extensions: No
  • Extra tools: No

Additional context
No

@tk0miya tk0miya added this to the 3.5.0 milestone Jan 10, 2021
tk0miya added a commit to tk0miya/sphinx that referenced this issue Jan 10, 2021
Sadly HTML and LaTeX writers compares the highlight languages using
`is` operator.  As a result, it has not worked even if languages are
same.  This replaces the comparison operator by `==`.
tk0miya added a commit that referenced this issue Jan 11, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

1 participant