Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

viewcode does not work when make singlehtml html #8704

Closed
tk0miya opened this issue Jan 18, 2021 · 0 comments
Closed

viewcode does not work when make singlehtml html #8704

tk0miya opened this issue Jan 18, 2021 · 0 comments
Labels
type:bug
Milestone
3.5.0

Comments

@tk0miya
Copy link
Member

tk0miya commented Jan 18, 2021

Describe the bug
viewcode does not work when make clean html

To Reproduce

$ make clean singlehtml html

Expected behavior
Always enabled for HTML builds (except singlehtml and epub)

Your project
No

Screenshots
No

Environment info

  • OS: Mac
  • Python version: 3.9.1
  • Sphinx version: HEAD of 3.x
  • Sphinx extensions: sphinx.ext.viewcode
  • Extra tools: No

Additional context
No
@tk0miya tk0miya added this to the 3.5.0 milestone Jan 18, 2021
tk0miya added a commit to tk0miya/sphinx that referenced this issue Jan 19, 2021
@tk0miya
Fix sphinx-doc#8704: viewcode: anchors are generated in incremental b…
25c1ba3 
…uild

The anchors for viewcode was generated in the reading phase only if
supported builder is used.  It causes anchors are missing on the
incremental build after the build for non supported builder.

This introduces `viewcode_anchor` node to insert the anchor even if non
supported builders.  They will be converted to the anchor tag in the
resolving phase for supported builders.  Or, they will be removed for
non supported builders.
tk0miya added a commit to tk0miya/sphinx that referenced this issue Jan 21, 2021
@tk0miya
Fix sphinx-doc#8704: viewcode: anchors are generated in incremental b…
84f2bfe 
…uild

The anchors for viewcode was generated in the reading phase only if
supported builder is used.  It causes anchors are missing on the
incremental build after the build for non supported builder.

This introduces `viewcode_anchor` node to insert the anchor even if non
supported builders.  They will be converted to the anchor tag in the
resolving phase for supported builders.  Or, they will be removed for
non supported builders.
tk0miya added a commit to tk0miya/sphinx that referenced this issue Jan 22, 2021
@tk0miya
Fix sphinx-doc#8704: viewcode: anchors are generated in incremental b…
59835c3 
…uild

The anchors for viewcode was generated in the reading phase only if
supported builder is used.  It causes anchors are missing on the
incremental build after the build for non supported builder.

This introduces `viewcode_anchor` node to insert the anchor even if non
supported builders.  They will be converted to the anchor tag in the
resolving phase for supported builders.  Or, they will be removed for
non supported builders.
tk0miya added a commit that referenced this issue Jan 22, 2021
@tk0miya
Merge pull request #8707 from tk0miya/8704_viewcode_not_working
d5bc970 
Fix #8704: viewcode: anchors are generated in incremental build
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
type:bug
Projects
None yet
Milestone
3.5.0
Development

No branches or pull requests
1 participant
@tk0miya