Remove unnecesary sleep when submitting parallel tasks #9097
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature or Bugfix
Purpose
ParallelTasks.add_task
calls_join_one
to poll for finished workers and possibly start the just-submitted task. However, it will also trigger thetime.sleep
call if no sub-processes are completed which unnecessarily slows down the launching of workers. Instead, I raise thetime.sleep
call intojoin
so thatadd_task
never starts a sleep.The sleep is only 20 ms per task so this doesn't make a huge difference.